Skip to content

spear-image: read labels from the neutral spear.* namespace - #9

Merged
daniel-rossier merged 1 commit into
mainfrom
spear-image-labels
Nov 14, 2026
Merged

daniel-rossier merged 1 commit into
mainfrom
spear-image-labels

Conversation

@daniel-rossier

Copy link
Copy Markdown
Contributor

What

Follow-up to #8. build-tiered.sh writes its image labels under the neutral spear.* namespace (which push.sh already reads), but spear-image inspect and list still looked only under the old ch.heig-vd.reds.spear.* namespace. A tiered image therefore showed a blank profile / redistributable under inspect, and did not appear in list at all.

Observed on a freshly built spear:0.3.0-harness: correct spear.profile=harness / spear.redistributable=true labels on the image, but spear-image inspect harness printed blank fields.

Fix

  • label() reads spear.<key> first and falls back to the old namespace, exactly as push.sh does — so tiered and legacy images both read.
  • list unions both namespaces so tiered (spear.profile) and legacy (ch.heig-vd.reds.spear.profile) images both appear.
  • Update the stale test_build_needs_a_profile assertion to the current build-profile message.

Tests

test_spear_image green (was 1 pre-existing failure, now fixed).

build-tiered.sh writes its labels under spear.* (as push.sh already reads),
but spear-image inspect/list still looked only under the old
ch.heig-vd.reds.spear.* namespace, so a tiered image showed a blank profile
and redistributable, and list did not show it at all. Read spear.* first and
fall back to the old namespace, exactly as push.sh does, and union both in
list so tiered and legacy images both appear. Update the stale
build-needs-a-profile assertion to the current message.
@daniel-rossier
daniel-rossier merged commit d7da5e3 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant